Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3426] - reverted method renaming #5803

Merged
merged 1 commit into from Jun 22, 2020

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
previous feature changed a public method introducing a breaking change

What is the new behaviour?
reverted the name as it was before.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #5803 into develop will increase coverage by 2.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5803      +/-   ##
===========================================
+ Coverage    83.88%   85.99%   +2.10%     
===========================================
  Files          960      178     -782     
  Lines        27174     5428   -21746     
  Branches      3790      763    -3027     
===========================================
- Hits         22796     4668   -18128     
+ Misses        3250      520    -2730     
+ Partials      1128      240     -888     
Impacted Files Coverage Δ
...omponents/search-header/search-header.component.ts 83.92% <ø> (ø)
...vices/src/lib/search/base-query-builder.service.ts 88.27% <100.00%> (ø)
lib/core/form/events/validate-form-field.event.ts
...atable/components/json-cell/json-cell.component.ts
...nents/activities/diagram-service-task.component.ts
...agram/models/diagram/diagram-pool-element.model.ts
...s-list/models/process-cloud-query-request.model.ts
...rc/lib/mock/process/process-instances-list.mock.ts
...onents/form-definition-selector-cloud.component.ts
.../src/lib/task/start-task/mock/task-details.mock.ts
... and 774 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b6c43...feb5204. Read the comment docs.

@VitoAlbano VitoAlbano force-pushed the dev-valbano-removed-method-rename branch from b0c269f to 7691c96 Compare June 22, 2020 13:59
@eromano
Copy link
Contributor

eromano commented Jun 22, 2020

/rebase

@github-actions github-actions bot force-pushed the dev-valbano-removed-method-rename branch from 7691c96 to feb5204 Compare June 22, 2020 14:28
@eromano eromano merged commit adfa9e2 into develop Jun 22, 2020
@eromano eromano deleted the dev-valbano-removed-method-rename branch June 22, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants