Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3426] Add translate pipe to search-header tooltip #5804

Merged
merged 3 commits into from Jun 22, 2020

Conversation

BaptisteMahe
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
There is no translate for column title inside the tooltip of the search-header.

What is the new behaviour?
The translater will look for a translation of the column title to display in the tooltip (in particular for use in ACA).

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@@ -5,7 +5,7 @@
#menuTrigger="matMenuTrigger"
(click)="onMenuButtonClick($event)"
class="adf-filter-button"
matTooltip="{{ 'SEARCH.SEARCH_HEADER.FILTER_BY' | translate: { category: col.title || 'Type' } }}">
matTooltip="{{ 'SEARCH.SEARCH_HEADER.FILTER_BY' | translate: { category: (col.title | translate) || 'Type' } }}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are doing double translation, and fallback value 'Type' is not translated. Better create a function that returns tooltip value.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2020

Codecov Report

Merging #5804 into develop will increase coverage by 2.10%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5804      +/-   ##
===========================================
+ Coverage    83.88%   85.99%   +2.10%     
===========================================
  Files          960      178     -782     
  Lines        27174     5434   -21740     
  Branches      3790      764    -3026     
===========================================
- Hits         22796     4673   -18123     
+ Misses        3250      520    -2730     
+ Partials      1128      241     -887     
Impacted Files Coverage Δ
...omponents/search-header/search-header.component.ts 83.87% <60.00%> (-0.06%) ⬇️
...re/form/components/widgets/people/people.widget.ts
.../core/card-view/models/card-view-dateitem.model.ts
...lib/task/task-filters/models/filter-cloud.model.ts
...components/raphael/raphael-flow-arrow.component.ts
lib/core/pagination/public-api.ts
lib/core/models/user-process.model.ts
...ts/src/lib/diagram/components/diagram.component.ts
.../mock/form/widget-visibility-cloud.service.mock.ts
lib/core/services/identity-user.service.ts
... and 774 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62794e...e514858. Read the comment docs.

@eromano eromano merged commit 1daffc0 into develop Jun 22, 2020
@eromano eromano deleted the dev-baptiste-add-title-translate branch June 22, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants