Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown style #5810

Merged
merged 4 commits into from Jun 24, 2020
Merged

Fix unknown style #5810

merged 4 commits into from Jun 24, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jun 23, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
For dark theming the unknown text field is not readable

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #5810 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5810   +/-   ##
========================================
  Coverage    83.91%   83.91%           
========================================
  Files          963      963           
  Lines        27237    27237           
  Branches      3799     3799           
========================================
  Hits         22857    22857           
  Misses        3244     3244           
  Partials      1136     1136           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea7b19...d24a71e. Read the comment docs.

@eromano eromano requested a review from cristinaj as a code owner June 23, 2020 18:57
@eromano eromano merged commit 094f247 into develop Jun 24, 2020
@eromano eromano deleted the dev-eromano-unknown-style branch June 24, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants