Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3529] Custom filter doesn't work properly when Direction is set to ASC #5829

Merged
merged 9 commits into from Jul 7, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Jul 1, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3529

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #5829 into develop will decrease coverage by 0.00%.
The diff coverage is 82.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5829      +/-   ##
===========================================
- Coverage    83.94%   83.94%   -0.01%     
===========================================
  Files          963      965       +2     
  Lines        27244    27286      +42     
  Branches      3799     3805       +6     
===========================================
+ Hits         22869    22904      +35     
- Misses        3237     3242       +5     
- Partials      1138     1140       +2     
Impacted Files Coverage Δ
...ss-list/components/process-list-cloud.component.ts 80.50% <78.94%> (+1.86%) ⬆️
.../task-list/components/task-list-cloud.component.ts 83.46% <84.21%> (+1.32%) ⬆️
...atable/components/datatable/datatable.component.ts 88.23% <100.00%> (+0.06%) ⬆️
lib/core/services/translate-loader.service.ts 72.15% <0.00%> (-8.87%) ⬇️
.../process-list/models/process-list-sorting.model.ts 80.00% <0.00%> (ø)
...b/task/task-list/models/task-list-sorting.model.ts 80.00% <0.00%> (ø)
...t/components/process-instance-details.component.ts 84.90% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a107775...6d63656. Read the comment docs.

@mcchrys mcchrys marked this pull request as ready for review July 7, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants