Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3551] Show vs View button for attach widget. #5850

Merged

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3551

What is the new behaviour?
attachement actions

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano
Copy link
Contributor

eromano commented Jul 26, 2020

/rebase

@github-actions github-actions bot force-pushed the dev-siva-ACA-3551-change-attach-widget-show-to-view branch from 047bfbe to fe83f55 Compare July 26, 2020 21:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2020

Codecov Report

Merging #5850 into develop will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5850      +/-   ##
===========================================
+ Coverage    76.06%   76.39%   +0.32%     
===========================================
  Files          843      834       -9     
  Lines        18726    18472     -254     
  Branches      3684     3617      -67     
===========================================
- Hits         14244    14111     -133     
+ Misses        3361     3251     -110     
+ Partials      1121     1110      -11     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
...b/extensions/src/lib/services/extension.service.ts
lib/extensions/src/lib/config/extension-utils.ts
...sions/src/lib/services/extension-loader.service.ts
lib/extensions/src/test.ts
lib/extensions/src/lib/config/action.extensions.ts
lib/extensions/src/lib/services/rule.service.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
...ons/src/lib/services/component-register.service.ts
.../components/dynamic-component/dynamic.component.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bf60e...17136ec. Read the comment docs.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3551-change-attach-widget-show-to-view branch from fe83f55 to b92bba3 Compare July 27, 2020 05:10
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3551-change-attach-widget-show-to-view branch from b92bba3 to 17136ec Compare July 30, 2020 04:49
@popovicsandras popovicsandras merged commit b8a3afc into develop Jul 31, 2020
@popovicsandras popovicsandras deleted the dev-siva-ACA-3551-change-attach-widget-show-to-view branch July 31, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants