Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3603] Destination picker is not opening on My Files when clicking on Attach file widget #5865

Merged
merged 4 commits into from Aug 13, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3603

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020

Codecov Report

Merging #5865 into develop will increase coverage by 2.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5865      +/-   ##
===========================================
+ Coverage    76.41%   78.43%   +2.02%     
===========================================
  Files          845      334     -511     
  Lines        18738     8986    -9752     
  Branches      3714     1799    -1915     
===========================================
- Hits         14318     7048    -7270     
+ Misses        3300     1387    -1913     
+ Partials      1120      551     -569     
Impacted Files Coverage Δ
...ntent-node-selector/content-node-dialog.service.ts 75.86% <0.00%> (-1.34%) ⬇️
.../src/lib/site-dropdown/sites-dropdown.component.ts 88.13% <ø> (ø)
...ontent-widget/attach-file-widget-dialog.service.ts 92.30% <ø> (ø)
...lib/content-widget/attach-file-widget.component.ts 70.78% <100.00%> (ø)
...atable/components/date-cell/date-cell.component.ts
lib/core/services/user-preferences.service.ts
...re/form/components/widgets/core/container.model.ts
...core/directives/version-compatibility.directive.ts
...m/components/icons/diagram-icon-error.component.ts
...e/form/components/widgets/core/form-field.model.ts
... and 505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec04d3...2affee8. Read the comment docs.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3603-destination-picker branch 2 times, most recently from 160fa24 to b09140d Compare August 5, 2020 07:23
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3603-destination-picker branch from 240a164 to b3b57a0 Compare August 6, 2020 05:22
@arditdomi arditdomi force-pushed the dev-siva-ACA-3603-destination-picker branch from b3b57a0 to 411ca65 Compare August 12, 2020 09:32
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3603-destination-picker branch from 411ca65 to 3af732d Compare August 13, 2020 08:53
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3603-destination-picker branch 2 times, most recently from 0f5d885 to c3a2b45 Compare August 13, 2020 09:15
@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3603-destination-picker branch from c3a2b45 to 2affee8 Compare August 13, 2020 09:20
@DenysVuika DenysVuika merged commit eb5d0da into develop Aug 13, 2020
@DenysVuika DenysVuika deleted the dev-siva-ACA-3603-destination-picker branch August 13, 2020 11:45
* shows files and folders in the dialog search result.
* @returns Information about the selected file(s)
*/
openFileBrowseDialogByDefaultLocation(): Observable<Node[]> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need it? if you have -my- it should already open to my

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants