use people api and new js api where possible #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromano
approved these changes
Jul 17, 2020
|
/rebase |
github-actions
bot
force-pushed
the
use-people-api
branch
from
ccb27d3
to
12c0519
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5888 +/- ##
===========================================
+ Coverage 76.38% 78.64% +2.26%
===========================================
Files 845 471 -374
Lines 18722 10745 -7977
Branches 3696 2007 -1689
===========================================
- Hits 14300 8450 -5850
+ Misses 3304 1661 -1643
+ Partials 1118 634 -484 Continue to review full report at Codecov.
|
|
@eromano I need to rework some unit tests for this PR |
DenysVuika
force-pushed
the
use-people-api
branch
from
12c0519
to
4b64dad
Compare
|
/rebase |
github-actions
bot
force-pushed
the
use-people-api
branch
from
2f6d164
to
eee8221
Compare
|
/rebase |
github-actions
bot
force-pushed
the
use-people-api
branch
from
eee8221
to
210ed9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
use People Api instead of legacy one
update custom resources service to remove legacy api usage
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: