Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3492] ADF - Expose new Groups Endpoints #5893

Merged
merged 6 commits into from Jul 22, 2020
Merged

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Jul 21, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
https://issues.alfresco.com/jira/browse/ACA-3492
Expose site groups apis

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #5893 into develop will decrease coverage by 7.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5893      +/-   ##
===========================================
- Coverage    83.94%   76.22%   -7.72%     
===========================================
  Files          963      839     -124     
  Lines        27244    18632    -8612     
  Branches      3799     3656     -143     
===========================================
- Hits         22869    14202    -8667     
- Misses        3237     3322      +85     
+ Partials      1138     1108      -30     
Impacted Files Coverage Δ
...nents/raphael/icons/raphael-icon-send.component.ts 14.28% <0.00%> (-61.91%) ⬇️
lib/core/form/events/form-error.event.ts 0.00% <0.00%> (-60.00%) ⬇️
lib/content-services/src/lib/content.module.ts 33.33% <0.00%> (-59.53%) ⬇️
lib/process-services/src/lib/process.module.ts 33.33% <0.00%> (-56.67%) ⬇️
lib/core/mock/alfresco-api.mock.ts 0.00% <0.00%> (-55.56%) ⬇️
...core/datatable/components/data-row-action.event.ts 0.00% <0.00%> (-54.55%) ⬇️
...mponents/activities/diagram-send-task.component.ts 33.33% <0.00%> (-52.39%) ⬇️
lib/insights/src/lib/insights.module.ts 33.33% <0.00%> (-51.29%) ⬇️
...ib/content-node-share/content-node-share.module.ts 33.33% <0.00%> (-50.01%) ⬇️
...src/lib/diagram/components/raphael/models/point.ts 0.00% <0.00%> (-50.00%) ⬇️
... and 904 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5257917...9d29b19. Read the comment docs.

@eromano eromano merged commit a5972e7 into develop Jul 22, 2020
@eromano eromano deleted the dev-dhrn-ACA-3492 branch July 22, 2020 10:20
mcchrys pushed a commit that referenced this pull request Jul 28, 2020
* [ACA-3492] ADF - Expose new Groups Endpoints

* * docs added

* * fix ut

* unit test split cloud

* Update data-table-component.page.ts

* unit test split cloud

Co-authored-by: Eugenio Romano <eugenio.romano@alfresco.com>
Co-authored-by: Eugenio Romano <eromano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants