Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3678] Disable save & delete buttons for default process filters #5896

Merged
merged 5 commits into from Jul 26, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Jul 21, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3678

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #5896 into develop will increase coverage by 2.35%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5896      +/-   ##
===========================================
+ Coverage    76.01%   78.37%   +2.35%     
===========================================
  Files          738      334     -404     
  Lines        16108     8877    -7231     
  Branches      3131     1768    -1363     
===========================================
- Hits         12245     6957    -5288     
+ Misses        2932     1371    -1561     
+ Partials       931      549     -382     
Impacted Files Coverage Δ
.../components/edit-process-filter-cloud.component.ts 72.00% <50.00%> (ø)
...s-filters/services/process-filter-cloud.service.ts 73.52% <100.00%> (ø)
...omponents/filesize-cell/filesize-cell.component.ts
...hts/src/lib/mock/diagram/diagram-swimlanes.mock.ts
lib/core/services/ecm-user.service.ts
...yout/directives/sidenav-layout-header.directive.ts
lib/core/datatable/data/object-datacolumn.model.ts
...ts/src/lib/diagram/models/diagram/diagram.model.ts
.../widgets/dynamic-table/editors/text/text.editor.ts
.../widgets/dynamic-table/editors/date/date.editor.ts
... and 598 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a2f8c...91e8c4a. Read the comment docs.

@eromano eromano merged commit 8d43155 into develop Jul 26, 2020
@eromano eromano deleted the dev-mrc-aca-3678 branch July 26, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants