[AAE-3110] Move upload button inside the node selector dialog #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arditdomi
changed the title
arditdomi
force-pushed
the
dev-adomi-AAE-3110
branch
from
f593bbf
to
3eff62b
Compare
...ent-services/src/lib/content-node-selector/content-node-selector.component-data.interface.ts
Show resolved
Hide resolved
| @@ -34,4 +34,6 @@ export interface ContentNodeSelectorComponentData { | |||
| showSearch?: boolean; | |||
| showFilesInResult?: boolean; | |||
| showDropdownSiteList?: boolean; | |||
| showUploadButton?: boolean; | |||
There was a problem hiding this comment.
showLocalUploadButton ?
lib/content-services/src/lib/content-node-selector/content-node-selector.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/content-node-selector/content-node-selector.module.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/document-list/components/document-list.component.ts
Outdated
Show resolved
Hide resolved
| @@ -342,6 +344,18 @@ export class DocumentListComponent implements OnInit, OnChanges, OnDestroy, Afte | |||
| .subscribe(pagSize => { | |||
| this.maxItems = this._pagination.maxItems = pagSize; | |||
| }); | |||
|
|
|||
| this.uploadService.fileUploadComplete | |||
There was a problem hiding this comment.
I think it would be better to have a NotificationService.nodesDataChanged().subscribe(this.reload)
arditdomi
force-pushed
the
dev-adomi-AAE-3110
branch
2 times, most recently
from
7deedbf
to
fc08f28
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5901 +/- ##
===========================================
- Coverage 76.11% 75.93% -0.19%
===========================================
Files 843 692 -151
Lines 18748 14589 -4159
Branches 3690 2844 -846
===========================================
- Hits 14270 11078 -3192
+ Misses 3363 2661 -702
+ Partials 1115 850 -265
Continue to review full report at Codecov.
|
sivakumar414ram
requested review from
DenysVuika,
eromano,
m-hulbert and
popovicsandras
as code owners
* Fixed failing unit tests
* Skipped failing e2e
sivakumar414ram
force-pushed
the
dev-adomi-AAE-3110
branch
from
7d423e4
to
90f7692
Compare
mauriziovitale
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3110
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: