Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3084] Add retrieve metadata option in upload widget #5903

Merged
merged 5 commits into from Aug 10, 2020

Conversation

pmartinezga
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
There is no way to refresh the form values based on the value of another component

What is the new behaviour?
When the upload widget that is marked with the retrieve metadata flag changes its value, then the other form fields will be updated with the value of the properties that match the name of the property

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #5903 into develop will increase coverage by 0.34%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5903      +/-   ##
===========================================
+ Coverage    76.38%   76.72%   +0.34%     
===========================================
  Files          844      835       -9     
  Lines        18664    18430     -234     
  Branches      3686     3623      -63     
===========================================
- Hits         14256    14140     -116     
+ Misses        3299     3188     -111     
+ Partials      1109     1102       -7     
Impacted Files Coverage Δ
.../attach-file/attach-file-cloud-widget.component.ts 90.69% <80.00%> (-3.42%) ⬇️
...ud/src/lib/form/components/form-cloud.component.ts 84.74% <88.88%> (+0.34%) ⬆️
lib/core/form/services/form.service.ts 60.65% <100.00%> (+0.32%) ⬆️
...rvices-cloud/src/lib/form/mocks/cloud-form.mock.ts 100.00% <100.00%> (ø)
...lib/process-comments/process-comments.component.ts 61.53% <0.00%> (-2.57%) ⬇️
lib/extensions/src/test.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
lib/extensions/src/lib/services/rule.service.ts
lib/extensions/src/lib/config/extension-utils.ts
...ons/src/lib/services/component-register.service.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7c996...7c1b5d4. Read the comment docs.

@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch 3 times, most recently from a251170 to 6144da7 Compare July 29, 2020 07:06
@pmartinezga pmartinezga marked this pull request as ready for review July 29, 2020 07:06
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 6144da7 to 3ad91b8 Compare July 30, 2020 05:54
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will be better to add this option in the File menu at least in case of multiple files . the code in the subscribe deserve a method and please don't use the string as 'upload'for field type but the enum FormFieldTypes.UPLOAD

@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from cfb1ab3 to 72d9203 Compare July 31, 2020 09:34
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 72d9203 to 3b22857 Compare July 31, 2020 10:10
@pmartinezga pmartinezga changed the title [AAE-3084] Subscribe to node selection changes when retrieving metadata flag is true [AAE-3084] Add retrieve metadata option in upload widget Jul 31, 2020
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 6d008bb to 6ecd92e Compare August 1, 2020 07:33
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 260c157 to ad11f80 Compare August 5, 2020 09:30
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from ad11f80 to b90d15e Compare August 5, 2020 18:40
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from b90d15e to 95614b7 Compare August 6, 2020 10:55
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 95614b7 to 18450b7 Compare August 6, 2020 15:00
@pmartinezga pmartinezga force-pushed the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch from 18450b7 to 7c1b5d4 Compare August 9, 2020 21:14
@eromano eromano merged commit aeff60a into develop Aug 10, 2020
@eromano eromano deleted the dev-pmartinezga-AAE-3084-use-node-metadata-in-form branch August 10, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants