Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-100] View a previous version #5913

Merged
merged 1 commit into from Jul 27, 2020
Merged

Conversation

ursedaniel
Copy link
Contributor

@ursedaniel ursedaniel commented Jul 24, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

https://issues.alfresco.com/jira/browse/ACA-100

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2020

Codecov Report

Merging #5913 into develop will increase coverage by 2.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5913      +/-   ##
===========================================
+ Coverage    76.20%   78.61%   +2.40%     
===========================================
  Files          839      471     -368     
  Lines        18646    10656    -7990     
  Branches      3659     1985    -1674     
===========================================
- Hits         14210     8377    -5833     
+ Misses        3329     1646    -1683     
+ Partials      1107      633     -474     
Impacted Files Coverage Δ
.../src/lib/version-manager/version-list.component.ts 83.33% <100.00%> (+1.11%) ⬆️
...c/lib/version-manager/version-manager.component.ts 64.51% <100.00%> (+2.44%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/datatable/data/data-table.schema.ts
.../core/services/dynamic-component-mapper.service.ts
...able/components/empty-list/empty-list.component.ts
...ib/core/form/components/widgets/core/form.model.ts
...onents/widgets/dynamic-table/editors/row.editor.ts
lib/core/services/discovery-api.service.ts
lib/core/services/get-type.ts
... and 359 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154ca07...810659e. Read the comment docs.

@montgolfiere
Copy link

montgolfiere commented Jul 27, 2020

Nice - finally green 👍

Ready to merge ?

@eromano eromano merged commit 7c09fb1 into develop Jul 27, 2020
@eromano eromano deleted the dev-durse-ACA-100-versions branch July 27, 2020 08:29
@montgolfiere
Copy link

Thanks @eromano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants