Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3637] - Add dueDate range filter #5919

Merged
merged 8 commits into from Sep 10, 2020
Merged

[ACA-3637] - Add dueDate range filter #5919

merged 8 commits into from Sep 10, 2020

Conversation

SilviuCPopa
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3624

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Silviu Popa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #5919 into develop will decrease coverage by 0.24%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5919      +/-   ##
===========================================
- Coverage    78.54%   78.29%   -0.25%     
===========================================
  Files          474      339     -135     
  Lines        10832     9087    -1745     
  Branches      2018     1811     -207     
===========================================
- Hits          8508     7115    -1393     
+ Misses        1687     1416     -271     
+ Partials       637      556      -81     
Impacted Files Coverage Δ
...ices-cloud/src/lib/common/process-common.module.ts 100.00% <ø> (ø)
...ocess-filters/models/process-filter-cloud.model.ts 70.96% <ø> (-5.35%) ⬇️
...lib/task/task-filters/task-filters-cloud.module.ts 100.00% <ø> (ø)
...ers/components/edit-task-filter-cloud.component.ts 71.50% <33.33%> (-2.10%) ⬇️
...mon/date-range-filter/date-range-filter.service.ts 86.95% <86.95%> (ø)
...n/date-range-filter/date-range-filter.component.ts 94.44% <93.33%> (+12.62%) ⬆️
...es-cloud/src/lib/models/date-cloud-filter.model.ts 100.00% <100.00%> (ø)
...lib/task/task-filters/models/filter-cloud.model.ts 76.74% <100.00%> (+2.38%) ⬆️
.../task-list/components/task-list-cloud.component.ts 82.82% <100.00%> (+0.35%) ⬆️
...rc/lib/task/task-list/models/filter-cloud-model.ts 95.83% <100.00%> (+0.37%) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6baf2...72ae855. Read the comment docs.

@SilviuCPopa SilviuCPopa marked this pull request as ready for review September 8, 2020 13:06
@eromano eromano merged commit de07e41 into develop Sep 10, 2020
@eromano eromano deleted the dev-spopa-ACA-3637 branch September 10, 2020 07:41
SilviuCPopa added a commit that referenced this pull request Sep 15, 2020
* [ACA-3637] - Add dueDate range filter

* update documentation

* [ACA-3637] - Add due date range filter

* update doc

* improvements

* remove unnecesarry file

* fix unit test

* fix codecov

Co-authored-by: Silviu Popa <p3701014@L3700101120.ness.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants