Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5204] Metadata - Error message still appears after exiting Edit form #5922

Merged
merged 3 commits into from Jul 29, 2020

Conversation

pionnegru
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ADF-5204

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #5922 into develop will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5922      +/-   ##
===========================================
+ Coverage    76.08%   76.39%   +0.30%     
===========================================
  Files          843      834       -9     
  Lines        18720    18467     -253     
  Branches      3682     3615      -67     
===========================================
- Hits         14243    14107     -136     
+ Misses        3357     3250     -107     
+ Partials      1120     1110      -10     
Impacted Files Coverage Δ
...card-view-textitem/card-view-textitem.component.ts 66.66% <100.00%> (+0.56%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
...b/extensions/src/lib/services/extension.service.ts
lib/extensions/src/lib/services/rule.service.ts
lib/extensions/src/lib/config/action.extensions.ts
lib/extensions/src/test.ts
...ons/src/lib/services/component-register.service.ts
.../components/dynamic-component/dynamic.component.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1581cfc...2dbfee9. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Jul 29, 2020

the failing test doesn't seem related to this change are failing in develop too

@eromano eromano merged commit 54df083 into develop Jul 29, 2020
@eromano eromano deleted the pionnegru-ADF-5204 branch July 29, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants