Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3643] - add completedBy filter on tasks #5924

Merged
merged 4 commits into from Sep 24, 2020

Conversation

SilviuCPopa
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3627

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Jul 29, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Silviu Popa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #5924 into develop will increase coverage by 2.53%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5924      +/-   ##
===========================================
+ Coverage    76.35%   78.89%   +2.53%     
===========================================
  Files          852      196     -656     
  Lines        19136     5282   -13854     
  Branches      3808     1083    -2725     
===========================================
- Hits         14612     4167   -10445     
+ Misses        3373      791    -2582     
+ Partials      1151      324     -827     
Impacted Files Coverage Δ
...lib/task/task-filters/task-filters-cloud.module.ts 100.00% <ø> (ø)
.../task-list/components/task-list-cloud.component.ts 83.00% <ø> (ø)
...ers/components/edit-task-filter-cloud.component.ts 73.45% <50.00%> (-0.69%) ⬇️
...lib/task/task-filters/models/filter-cloud.model.ts 79.66% <100.00%> (+0.71%) ⬆️
...rc/lib/task/task-list/models/filter-cloud-model.ts 96.15% <100.00%> (+0.15%) ⬆️
...n-manager/components/inherited-button.directive.ts
lib/core/services/shared-links-api.service.ts
...b/content-services/src/lib/search/search.module.ts
lib/core/context-menu/context-menu.tokens.ts
...nts/raphael/icons/raphael-icon-script.component.ts
... and 652 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe0412...32054f5. Read the comment docs.

@popovicsandras popovicsandras merged commit 0119c74 into develop Sep 24, 2020
@popovicsandras popovicsandras deleted the dev-spopa-ACA-3643 branch September 24, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants