Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3795] E2E test to validate Delete Save and Save as actions should be displayed and enabled when clicking on custom filter header #5930

Merged
merged 1 commit into from Jul 31, 2020

Conversation

bogdanapatrichi
Copy link
Contributor

  • Add createNewProcessCustomFilter() method in edit-process-filters-component.e2e.ts

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: Delete Save and Save as actions should be displayed and enabled when clicking on custom filter header

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…d be displayed and enabled when clicking on custom filter header

* Add createNewProcessCustomFilter() method in edit-process-filters-component.e2e.ts
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #5930 into develop will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5930      +/-   ##
===========================================
- Coverage    78.59%   78.22%   -0.37%     
===========================================
  Files          471      142     -329     
  Lines        10697     3885    -6812     
  Branches      1996      773    -1223     
===========================================
- Hits          8407     3039    -5368     
+ Misses        1653      598    -1055     
+ Partials       637      248     -389     
Impacted Files Coverage Δ
.../lib/upload/directives/file-draggable.directive.ts 32.65% <0.00%> (-1.39%) ⬇️
...ights/src/lib/diagram/services/diagrams.service.ts
.../diagram/models/chart/details-table-chart.model.ts
...ents/raphael/icons/raphael-icon-camel.component.ts
...s-cloud/src/lib/services/form-fields.interfaces.ts
...ts/raphael/icons/raphael-icon-message.component.ts
...ervices-cloud/src/lib/app/app-list-cloud.module.ts
...m/components/gateways/diagram-gateway.component.ts
...ervices/src/lib/mock/process/process.model.mock.ts
.../task-list/components/task-standalone.component.ts
... and 320 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7a090...159a6ad. Read the comment docs.

@eromano eromano merged commit 1e8c146 into develop Jul 31, 2020
@eromano eromano deleted the dev-petra-aca-3795 branch July 31, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants