Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-612] Support for Form Outcome Visibility Conditions #5934

Merged
merged 1 commit into from Jul 30, 2020

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Jul 30, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-612
Visibility Conditions are not evaluated on Form Outcomes.

What is the new behaviour?
Visibility conditions for Outcomes are now evaluated. This means we can have dynamic outcomes based on different conditions.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #5934 into develop will decrease coverage by 2.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5934      +/-   ##
===========================================
- Coverage    78.59%   76.45%   -2.14%     
===========================================
  Files          471      834     +363     
  Lines        10697    18499    +7802     
  Branches      1996     3624    +1628     
===========================================
+ Hits          8407    14143    +5736     
- Misses        1653     3251    +1598     
- Partials       637     1105     +468     
Impacted Files Coverage Δ
...rvices-cloud/src/lib/form/mocks/cloud-form.mock.ts 100.00% <ø> (ø)
...form/components/widgets/core/form-outcome.model.ts 100.00% <100.00%> (ø)
...ib/core/form/services/widget-visibility.service.ts 87.24% <100.00%> (ø)
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
.../lib/upload/directives/file-draggable.directive.ts 32.65% <0.00%> (-1.39%) ⬇️
...ib/core/form/components/widgets/core/form.model.ts 86.86% <0.00%> (ø)
lib/core/language-menu/language-menu.module.ts 100.00% <0.00%> (ø)
lib/core/context-menu/context-menu.service.ts 100.00% <0.00%> (ø)
lib/core/pipes/full-name.pipe.ts 90.90% <0.00%> (ø)
lib/core/mock/form/form.component.mock.ts 100.00% <0.00%> (ø)
... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7a090...2409cab. Read the comment docs.

@eromano eromano merged commit 1e69225 into develop Jul 30, 2020
@eromano eromano deleted the dev-dcano-AAE-612 branch July 30, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants