Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3203] Add tooltip to Form Cloud Widgets #5947

Merged
merged 1 commit into from Aug 3, 2020
Merged

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Aug 3, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3203

What is the new behaviour?
The Form Cloud Fields are able to display a tooltip when this property is specified in the form definition.

Screen Shot 2020-08-03 at 19 12 42

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #5947 into develop will increase coverage by 2.87%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5947      +/-   ##
===========================================
+ Coverage    76.06%   78.93%   +2.87%     
===========================================
  Files          843      370     -473     
  Lines        18764     8166   -10598     
  Branches      3690     1465    -2225     
===========================================
- Hits         14272     6446    -7826     
+ Misses        3378     1258    -2120     
+ Partials      1114      462     -652     
Impacted Files Coverage Δ
lib/core/mock/event.mock.ts
lib/core/mock/app-config.service.mock.ts
...ponents/unknown-format/unknown-format.component.ts
...ib/core/login/components/login-dialog.component.ts
lib/core/models/identity-role.model.ts
...yout/directives/sidenav-layout-header.directive.ts
lib/core/pagination/pagination.component.ts
lib/core/material.module.ts
.../components/edit-process-filter-cloud.component.ts
...re/form/components/form-custom-button.directive.ts
... and 462 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66ad49...88e944f. Read the comment docs.

@eromano eromano merged commit 1ade912 into develop Aug 3, 2020
@eromano eromano deleted the dev-dcano-aae-2378 branch August 3, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants