New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADF-3499] Make Card View Text Item reactive to user input #5953
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5953 +/- ##
===========================================
- Coverage 77.77% 76.65% -1.12%
===========================================
Files 143 841 +698
Lines 4005 18753 +14748
Branches 801 3698 +2897
===========================================
+ Hits 3115 14376 +11261
- Misses 632 3249 +2617
- Partials 258 1128 +870
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the tests are going to be flaky, as you removed async
but not calling done()
. You can avoid done
only if the func is wrapped with fakeAsync
that some of the tests are missing.
fixture.detectChanges(); | ||
await fixture.whenStable(); | ||
fixture.whenStable().then(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be flaky. you need to call done()
in case you are not using async test
fixture.whenStable().then(() => { | ||
|
||
const value = getTextFieldValue(component.property.key); | ||
expect(value).toBe('User Name'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs done()
call
17f672b
to
dce5e67
Compare
2fa23c9
to
16fd0d8
Compare
16fd0d8
to
1f91809
Compare
1f91809
to
0af75a0
Compare
091c6d6
to
12aaa71
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3499
The Card View Text Item input required to click outside to trigger the change event.
What is the new behaviour?
The Card View Text Item input now makes use of a much ore modern form control instead of the ngModel it was using. This allows it to fire in a control manner.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: