Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-2718] List available roles for a group #5954

Merged
merged 5 commits into from Aug 6, 2020
Merged

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • introduce new OAuth2Service that unifies and simplifies custom api calls
  • add missing "available roles" for the group service
  • greatly cleanup Identity User and Group services, remove copy-pasted code
  • remove useless error rethrowing (apps should handle that better)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #5954 into develop will increase coverage by 0.60%.
The diff coverage is 75.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5954      +/-   ##
===========================================
+ Coverage    76.08%   76.69%   +0.60%     
===========================================
  Files          843      835       -8     
  Lines        18769    18410     -359     
  Branches      3691     3619      -72     
===========================================
- Hits         14281    14120     -161     
+ Misses        3378     3191     -187     
+ Partials      1110     1099      -11     
Impacted Files Coverage Δ
lib/core/services/identity-user.service.ts 67.18% <62.50%> (+10.47%) ⬆️
lib/core/services/identity-group.service.ts 68.42% <74.28%> (+1.75%) ⬆️
lib/core/mock/identity-group.service.mock.ts 100.00% <100.00%> (+11.11%) ⬆️
lib/core/services/oauth2.service.ts 100.00% <100.00%> (ø)
lib/extensions/src/test.ts
...b/extensions/src/lib/services/extension.service.ts
...sions/src/lib/services/extension-loader.service.ts
.../components/dynamic-component/dynamic.component.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/services/rule.service.ts
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd012d...fb77e7a. Read the comment docs.

@DenysVuika DenysVuika merged commit 486a002 into develop Aug 6, 2020
@DenysVuika DenysVuika deleted the group-role-mapping branch August 6, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants