Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process-task-attach-content-file-cloud.e2e.ts afterAll #5963

Merged
merged 1 commit into from Aug 8, 2020

Conversation

cristinaj
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #5963 into develop will increase coverage by 1.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5963      +/-   ##
===========================================
+ Coverage    76.17%   78.16%   +1.98%     
===========================================
  Files          743      142     -601     
  Lines        16112     3920   -12192     
  Branches      3156      780    -2376     
===========================================
- Hits         12274     3064    -9210     
+ Misses        2898      603    -2295     
+ Partials       940      253     -687     
Impacted Files Coverage Δ
...ocess-list/components/process-filters.component.ts
...nalytics/analytics-params-report-component.mock.ts
...omponents/filesize-cell/filesize-cell.component.ts
...-view/validators/card-view-item-length.valiator.ts
...ts/gateways/diagram-exclusive-gateway.component.ts
lib/core/services/auth-guard-base.ts
lib/core/mock/authentication.service.mock.ts
...orm/components/widgets/core/error-message.model.ts
...lib/task-list/components/task-filters.component.ts
...b/core/viewer/components/media-player.component.ts
... and 591 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61cac20...5f4d730. Read the comment docs.

@DenysVuika DenysVuika merged commit 7b7c996 into develop Aug 8, 2020
@DenysVuika DenysVuika deleted the dev-crisj-fix-test branch August 8, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants