Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3258] Update simpleapp #5982

Merged
merged 1 commit into from Aug 12, 2020
Merged

[AAE-3258] Update simpleapp #5982

merged 1 commit into from Aug 12, 2020

Conversation

rdiacenco
Copy link
Contributor

  • Update multiinstance-dmnsequence process
  • Due to recent changes added to multi instance processes

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: E2E precondition update

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

* Update multiinstance-dmnsequence process
* Due to recent changes added to multi instance processes
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #5982 into develop will increase coverage by 2.17%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5982      +/-   ##
===========================================
+ Coverage    75.90%   78.08%   +2.17%     
===========================================
  Files          703      142     -561     
  Lines        14802     3928   -10874     
  Branches      2917      787    -2130     
===========================================
- Hits         11236     3067    -8169     
+ Misses        2701      610    -2091     
+ Partials       865      251     -614     
Impacted Files Coverage Δ
...ata/services/property-groups-translator.service.ts 96.22% <ø> (ø)
...document-list/services/custom-resources.service.ts 71.54% <72.22%> (ø)
.../core/layout/components/header/header.component.ts
...-view/validators/card-view-item-length.valiator.ts
...nsights/src/lib/mock/diagram/diagram-flows.mock.ts
...b/core/pagination/infinite-pagination.component.ts
.../src/lib/process-list/models/process-list.model.ts
...activities/diagram-business-rule-task.component.ts
lib/core/buttons-menu/buttons-menu.module.ts
...sions/src/lib/services/extension-loader.service.ts
... and 836 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa936b...c964240. Read the comment docs.

@eromano eromano merged commit 47883a3 into develop Aug 12, 2020
@eromano eromano deleted the dev-rdiacenco-AAE-3258 branch August 12, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants