Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flex-layout version #6040

Merged
merged 1 commit into from Aug 20, 2020
Merged

fix flex-layout version #6040

merged 1 commit into from Aug 20, 2020

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

fix typo in the version of flex-layout dependency
fixes #6039

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #6040 into develop will increase coverage by 3.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6040      +/-   ##
===========================================
+ Coverage    76.35%   79.47%   +3.11%     
===========================================
  Files          845       91     -754     
  Lines        18759     2490   -16269     
  Branches      3716      473    -3243     
===========================================
- Hits         14324     1979   -12345     
+ Misses        3314      384    -2930     
+ Partials      1121      127     -994     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
lib/core/services/startup-service-factory.ts
...rm/services/content-cloud-node-selector.service.ts
...ocess-filters/models/process-filter-cloud.model.ts
...filters/components/task-filters-cloud.component.ts
lib/core/services/people-content.service.ts
...ponents/structural/diagram-subprocess.component.ts
lib/core/pipes/format-space.pipe.ts
lib/core/comments/comment-list.component.ts
...-view/validators/card-view-item-length.valiator.ts
... and 745 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c37289...9d8df21. Read the comment docs.

@eromano eromano merged commit cd057c8 into develop Aug 20, 2020
@eromano eromano deleted the fix-flex-layout-version branch August 20, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error in @angular/flex-layout package version in content-services/package.json
3 participants