Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish improvements #6067

Merged
merged 2 commits into from Aug 25, 2020
Merged

publish improvements #6067

merged 2 commits into from Aug 25, 2020

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #6067 into develop will increase coverage by 1.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6067      +/-   ##
===========================================
+ Coverage    75.26%   76.26%   +1.00%     
===========================================
  Files          618      846     +228     
  Lines        14545    18807    +4262     
  Branches      3029     3719     +690     
===========================================
+ Hits         10947    14344    +3397     
- Misses        2688     3341     +653     
- Partials       910     1122     +212     
Impacted Files Coverage Δ
lib/core/services/oauth2.service.ts 100.00% <ø> (ø)
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
.../process-list/components/process-list.component.ts 84.78% <0.00%> (ø)
...nalytics-process/components/analytics.component.ts 45.45% <0.00%> (ø)
...s/structural/diagram-event-subprocess.component.ts 100.00% <0.00%> (ø)
...ib/analytics-process/services/analytics.service.ts 75.72% <0.00%> (ø)
...lib/task-list/components/task-filters.component.ts 65.45% <0.00%> (ø)
.../diagram/models/chart/details-table-chart.model.ts 40.00% <0.00%> (ø)
...ces/src/lib/form/process-form-rendering.service.ts 100.00% <0.00%> (ø)
...ts/src/lib/diagram/models/chart/bar-chart.model.ts 51.21% <0.00%> (ø)
... and 220 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da67b6f...2f04464. Read the comment docs.

@eromano eromano merged commit 70e9a72 into develop Aug 25, 2020
@eromano eromano deleted the npm-publish-improvements branch August 25, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants