Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3706] implement startedBy process filter property #6077

Merged
merged 10 commits into from Oct 23, 2020

Conversation

SilviuCPopa
Copy link
Contributor

@SilviuCPopa SilviuCPopa commented Aug 26, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3706

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:
The initiator filter has been replaced with https://github.com/Alfresco/alfresco-ng2-components/blob/develop/lib/process-services-cloud/src/lib/people/components/people-cloud.component.ts instead of the simple text input
Other information:

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #6077 into develop will increase coverage by 0.28%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6077      +/-   ##
===========================================
+ Coverage    76.24%   76.53%   +0.28%     
===========================================
  Files          862      853       -9     
  Lines        19415    19170     -245     
  Branches      3856     3795      -61     
===========================================
- Hits         14803    14671     -132     
+ Misses        3461     3356     -105     
+ Partials      1151     1143       -8     
Impacted Files Coverage Δ
lib/core/services/oauth2.service.ts 100.00% <ø> (ø)
...ss/process-filters/process-filters-cloud.module.ts 100.00% <ø> (ø)
.../components/edit-process-filter-cloud.component.ts 72.81% <22.22%> (-2.19%) ⬇️
...ss-list/components/process-list-cloud.component.ts 79.79% <75.00%> (-0.42%) ⬇️
...ocess-filters/models/process-filter-cloud.model.ts 79.03% <100.00%> (+0.34%) ⬆️
...s-list/models/process-cloud-query-request.model.ts 95.65% <100.00%> (ø)
lib/core/services/upload.service.ts 84.91% <0.00%> (-0.56%) ⬇️
lib/core/toolbar/toolbar.module.ts 100.00% <0.00%> (ø)
lib/extensions/src/lib/config/action.extensions.ts
.../components/dynamic-component/dynamic.component.ts
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877a9f0...913fc04. Read the comment docs.

Copy link
Contributor

@popovicsandras popovicsandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see Denys' requests

@pr-triage pr-triage bot removed the PR: draft label Sep 16, 2020
@eromano
Copy link
Contributor

eromano commented Sep 27, 2020

@SilviuCPopa is this PR still needed? if so can you bring it back in a mergeable state? thanks

@popovicsandras
Copy link
Contributor

Depends on the completedBy PR, as soon as that one is merged, we can rebase this. Anyway, this was moved to next version given its low priority.

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #6077 into develop will increase coverage by 0.37%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6077      +/-   ##
===========================================
+ Coverage    76.26%   76.64%   +0.37%     
===========================================
  Files          862      855       -7     
  Lines        19481    19276     -205     
  Branches      3881     3827      -54     
===========================================
- Hits         14858    14774      -84     
+ Misses        3463     3346     -117     
+ Partials      1160     1156       -4     
Impacted Files Coverage Δ
lib/core/services/oauth2.service.ts 100.00% <ø> (ø)
...ss/process-filters/process-filters-cloud.module.ts 100.00% <ø> (ø)
.../components/edit-process-filter-cloud.component.ts 74.64% <50.00%> (-0.36%) ⬇️
...k-filters/base-edit-task-filter-cloud.component.ts 77.24% <50.00%> (-0.87%) ⬇️
...ocess-filters/models/process-filter-cloud.model.ts 79.03% <100.00%> (+0.34%) ⬆️
.../components/search-panel/search-panel.component.ts 80.00% <0.00%> (-20.00%) ⬇️
...lib/process-comments/process-comments.component.ts 61.53% <0.00%> (-2.57%) ⬇️
...-selector/content-node-selector-panel.component.ts 85.32% <0.00%> (-0.23%) ⬇️
...lib/task/task-filters/task-filters-cloud.module.ts 100.00% <0.00%> (ø)
lib/extensions/src/lib/services/rule.service.ts
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072f910...8f5e3cd. Read the comment docs.

@popovicsandras popovicsandras merged commit 1f163d5 into develop Oct 23, 2020
@popovicsandras popovicsandras deleted the dev-spopa-ACA-3706 branch October 23, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants