New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-3706] implement startedBy process filter property #6077
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6077 +/- ##
===========================================
+ Coverage 76.24% 76.53% +0.28%
===========================================
Files 862 853 -9
Lines 19415 19170 -245
Branches 3856 3795 -61
===========================================
- Hits 14803 14671 -132
+ Misses 3461 3356 -105
+ Partials 1151 1143 -8
Continue to review full report at Codecov.
|
...ices-cloud/src/lib/process/process-filters/components/edit-process-filter-cloud.component.ts
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/process/process-filters/process-filters-cloud.module.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see Denys' requests
@SilviuCPopa is this PR still needed? if so can you bring it back in a mergeable state? thanks |
Depends on the completedBy PR, as soon as that one is merged, we can rebase this. Anyway, this was moved to next version given its low priority. |
a3186c4
to
913fc04
Compare
913fc04
to
9175fbb
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6077 +/- ##
===========================================
+ Coverage 76.26% 76.64% +0.37%
===========================================
Files 862 855 -7
Lines 19481 19276 -205
Branches 3881 3827 -54
===========================================
- Hits 14858 14774 -84
+ Misses 3463 3346 -117
+ Partials 1160 1156 -4
Continue to review full report at Codecov.
|
9175fbb
to
71a66b7
Compare
71a66b7
to
980d96a
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3706
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
The initiator filter has been replaced with https://github.com/Alfresco/alfresco-ng2-components/blob/develop/lib/process-services-cloud/src/lib/people/components/people-cloud.component.ts instead of the simple text input
Other information: