Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3321] Select uploaded local files by default #6079

Merged
merged 8 commits into from Sep 14, 2020

Conversation

sivakumar414ram
Copy link
Contributor

@sivakumar414ram sivakumar414ram commented Aug 26, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/AAE-3321

What is the new behaviour?

content-node-panel-preselect

document-list-preselect

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Aug 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #6079 into develop will increase coverage by 0.66%.
The diff coverage is 77.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6079      +/-   ##
===========================================
+ Coverage    77.72%   78.38%   +0.66%     
===========================================
  Files          143      339     +196     
  Lines         3960     9139    +5179     
  Branches       788     1823    +1035     
===========================================
+ Hits          3078     7164    +4086     
- Misses         631     1416     +785     
- Partials       251      559     +308     
Impacted Files Coverage Δ
...-selector/content-node-selector-panel.component.ts 85.80% <35.29%> (-6.04%) ⬇️
.../lib/document-list/data/share-datatable-adapter.ts 72.72% <90.90%> (+2.23%) ⬆️
...ocument-list/components/document-list.component.ts 84.30% <95.83%> (+3.33%) ⬆️
...vices/src/lib/mock/document-list.component.mock.ts 100.00% <100.00%> (ø)
...lib/task/task-list/mock/fake-task-response.mock.ts 100.00% <0.00%> (ø)
...t/components/process-instance-details.component.ts 76.47% <0.00%> (ø)
...lib/content-widget/attach-file-widget.component.ts 70.78% <0.00%> (ø)
...cess-services/src/lib/app-list/apps-list.module.ts 100.00% <0.00%> (ø)
...rocess/components/start-process-cloud.component.ts 85.29% <0.00%> (ø)
...services/src/lib/testing/process.testing.module.ts 100.00% <0.00%> (ø)
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3c86d...ff4793d. Read the comment docs.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-AAE-3321 branch 4 times, most recently from 094b986 to ce3143d Compare August 28, 2020 14:27
@sivakumar414ram sivakumar414ram marked this pull request as ready for review August 28, 2020 14:46
Copy link
Contributor

@mauriziovitale mauriziovitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test

@pr-triage pr-triage bot removed the PR: unreviewed label Sep 2, 2020
@mauriziovitale mauriziovitale merged commit 6fa0254 into develop Sep 14, 2020
@mauriziovitale mauriziovitale deleted the dev-siva-AAE-3321 branch September 14, 2020 08:07
SilviuCPopa pushed a commit that referenced this pull request Sep 15, 2020
* [AAE-3111] Select uploaded files by default

* [AAE-3321] Select uploaded local files by default

* * After rebase

* *  Renamed method/property names

* * Fixed comments
* Added a private method to bubble up preselected nodes

* * Added unit tests

* * Fixed typo* added doc* Preselect based on the selection mode

* * Added way to test in demo shell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants