[ACA-3441] Add method to attach file widget PO #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinaj
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
eromano
reviewed
Aug 28, 2020
| await BrowserActions.click(uploadButton); | ||
| await BrowserVisibility.waitUntilElementIsPresent(this.localStorageButton); | ||
| await this.localStorageButton.sendKeys(fileLocation); | ||
| } | ||
|
|
||
| async checkNoFileIsAttached(fieldId): Promise<void> { |
There was a problem hiding this comment.
Not sure I can really understand the difference from the name of:
checkNoFileIsAttached checkFileIsNotAttached
checkFileIsAttached checkFilesAreAttachedToWidget
There was a problem hiding this comment.
checkNoFileIsAttached -> this checks that no file is attached; checkFileIsNotAttached -> this checks that a specific file is not attached, others may be; checkFileIsAttached -> checks that a specific file is attached; checkFilesAreAttachedToWidget -> you can give multiple files as parameter
cristinaj
force-pushed
the
dev-crisj-ACA-3441
branch
from
2b97571
to
92c8359
Compare
cristinaj
force-pushed
the
dev-crisj-ACA-3441
branch
from
d9e1cfe
to
2971c60
Compare
SilviuCPopa
pushed a commit
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: