Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5230] - Implement process date range filter #6086

Merged
merged 2 commits into from Sep 7, 2020

Conversation

SilviuCPopa
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-5230

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Silviu Popa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #6086 into develop will increase coverage by 2.39%.
The diff coverage is 85.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6086      +/-   ##
===========================================
+ Coverage    75.88%   78.27%   +2.39%     
===========================================
  Files          703      337     -366     
  Lines        14847     9060    -5787     
  Branches      2931     1801    -1130     
===========================================
- Hits         11266     7092    -4174     
+ Misses        2710     1414    -1296     
+ Partials       871      554     -317     
Impacted Files Coverage Δ
...ss/process-filters/process-filters-cloud.module.ts 100.00% <ø> (ø)
...n/date-range-filter/date-range-filter.component.ts 81.81% <81.81%> (ø)
...ices-cloud/src/lib/common/process-common.module.ts 100.00% <100.00%> (ø)
...ocess-filters/models/process-filter-cloud.model.ts 76.31% <100.00%> (+5.34%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/viewer/viewer.module.ts
...m/models/diagram/diagram-event-definition.model.ts
lib/extensions/src/lib/config/extension-utils.ts
lib/core/datatable/data/data-sorting.model.ts
lib/core/form/models/widget-visibility.model.ts
... and 651 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11237a...8d3a6e1. Read the comment docs.

@SilviuCPopa SilviuCPopa force-pushed the dev-spopa-ADF-5230 branch 2 times, most recently from 1e8d87e to f8a30e2 Compare September 2, 2020 12:22
@popovicsandras popovicsandras merged commit 8d6baf2 into develop Sep 7, 2020
@popovicsandras popovicsandras deleted the dev-spopa-ADF-5230 branch September 7, 2020 13:05
SilviuCPopa added a commit that referenced this pull request Sep 15, 2020
* [ADF-5230] - Implement process date range filter

* i18n

Co-authored-by: Silviu Popa <p3701014@L3700101120.ness.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants