Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5219] Refactor Document list Filters #6092

Merged
merged 8 commits into from Sep 25, 2020
Merged

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Sep 2, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-5219

What is the new behaviour?
The document list filters have been refactored to make them easier to implement.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #6092 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6092      +/-   ##
===========================================
+ Coverage    76.29%   76.39%   +0.09%     
===========================================
  Files          852      699     -153     
  Lines        19067    14872    -4195     
  Branches      3779     2940     -839     
===========================================
- Hits         14548    11362    -3186     
+ Misses        3378     2628     -750     
+ Partials      1141      882     -259     
Impacted Files Coverage Δ
lib/core/datatable/datatable.module.ts 100.00% <ø> (ø)
...n/date-range-filter/date-range-filter.component.ts 92.59% <0.00%> (-1.86%) ⬇️
...mon/date-range-filter/date-range-filter.service.ts 86.36% <0.00%> (-0.60%) ⬇️
...lib/document-list/models/document-library.model.ts
...ntent-node-selector/content-node-dialog.service.ts
...rvices/src/lib/tree-view/models/tree-view.model.ts
...src/lib/upload/directives/toggle-icon.directive.ts
...rc/lib/mock/inherited-permission.component.mock.ts
lib/extensions/src/lib/config/action.extensions.ts
...ces/src/lib/site-dropdown/sites-dropdown.module.ts
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67b3b8...c9ffa15. Read the comment docs.

@DenysVuika DenysVuika merged commit b0a46f7 into develop Sep 25, 2020
@DenysVuika DenysVuika deleted the dev-dcano-ADF-5219 branch September 25, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants