Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3296] Add unit tests for Tooltips in Form Widgets #6094

Merged
merged 1 commit into from Sep 10, 2020

Conversation

davidcanonieto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Missing tests

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3296

What is the new behaviour?
Unit tests added for all widgets that make use of tooltips.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #6094 into develop will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6094      +/-   ##
===========================================
- Coverage    76.25%   75.69%   -0.57%     
===========================================
  Files          846      611     -235     
  Lines        18807    14332    -4475     
  Branches      3719     2963     -756     
===========================================
- Hits         14341    10848    -3493     
+ Misses        3344     2583     -761     
+ Partials      1122      901     -221     
Impacted Files Coverage Δ
...ss/process-filters/process-filters-cloud.module.ts 100.00% <0.00%> (ø)
...gram/components/raphael/raphael-cross.component.ts
...nalytics/analytics-params-report-component.mock.ts
...ces/src/lib/form/process-form-rendering.service.ts
...rc/lib/process-list/models/filter-process.model.ts
...ghts/src/lib/mock/diagram/diagram-boundary.mock.ts
...vices/src/lib/task-list/models/start-task.model.ts
...b/extensions/src/lib/services/extension.service.ts
.../src/lib/task-list/services/task-upload.service.ts
...es/src/lib/content-widget/content-widget.module.ts
... and 231 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c96e8...809f6c1. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Sep 4, 2020

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants