Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3877] Add the possibility to ADF Extension to be used in compila… #6097

Merged
merged 5 commits into from Sep 10, 2020

Conversation

popovicsandras
Copy link
Contributor

…tion time

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
See https://issues.alfresco.com/jira/browse/ACA-3877

What is the new behaviour?
Done

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #6097 into develop will decrease coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6097      +/-   ##
===========================================
- Coverage    76.29%   76.27%   -0.03%     
===========================================
  Files          850      850              
  Lines        18885    18889       +4     
  Branches      3731     3731              
===========================================
- Hits         14409    14408       -1     
- Misses        3350     3355       +5     
  Partials      1126     1126              
Impacted Files Coverage Δ
lib/extensions/src/lib/config/action.extensions.ts 100.00% <ø> (ø)
...b/extensions/src/lib/services/extension.service.ts 82.75% <80.00%> (-0.58%) ⬇️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26172f3...eb3edb6. Read the comment docs.

@eromano eromano merged commit ed53a02 into develop Sep 10, 2020
@eromano eromano deleted the dev-apopovics-ACA-3877 branch September 10, 2020 20:29
SilviuCPopa pushed a commit that referenced this pull request Sep 15, 2020
#6097)

* [ACA-3877] Add the possibility to ADF Extension to be used in compilation time

* Fix interface

* Fix cspell

* Fix unit tests

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants