Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include attach file test #6102

Merged
merged 5 commits into from Sep 10, 2020
Merged

include attach file test #6102

merged 5 commits into from Sep 10, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Sep 8, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano eromano marked this pull request as draft September 8, 2020 13:42
@eromano eromano removed the request for review from cristinaj September 8, 2020 13:42
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #6102 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6102   +/-   ##
========================================
  Coverage    76.27%   76.27%           
========================================
  Files          848      850    +2     
  Lines        18848    18885   +37     
  Branches      3720     3731   +11     
========================================
+ Hits         14376    14405   +29     
- Misses        3349     3354    +5     
- Partials      1123     1126    +3     
Impacted Files Coverage Δ
lib/core/services/auth-guard-ecm.service.ts 78.57% <0.00%> (-21.43%) ⬇️
...ocess-filters/models/process-filter-cloud.model.ts 70.96% <0.00%> (-5.35%) ⬇️
...ers/components/edit-task-filter-cloud.component.ts 71.50% <0.00%> (-2.10%) ⬇️
...ices-cloud/src/lib/common/process-common.module.ts 100.00% <0.00%> (ø)
...lib/task/task-filters/task-filters-cloud.module.ts 100.00% <0.00%> (ø)
...mon/date-range-filter/date-range-filter.service.ts 86.95% <0.00%> (ø)
...es-cloud/src/lib/models/date-cloud-filter.model.ts 100.00% <0.00%> (ø)
lib/core/viewer/components/viewer.component.ts 71.72% <0.00%> (+0.11%) ⬆️
lib/core/viewer/components/img-viewer.component.ts 90.00% <0.00%> (+0.22%) ⬆️
.../task-list/components/task-list-cloud.component.ts 82.82% <0.00%> (+0.35%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57253f...fbc1d44. Read the comment docs.

@eromano eromano marked this pull request as ready for review September 10, 2020 20:28
@eromano eromano merged commit 5305d65 into develop Sep 10, 2020
@eromano eromano deleted the dev-eromano-include-attach-file branch September 10, 2020 20:28
SilviuCPopa pushed a commit that referenced this pull request Sep 15, 2020
* include attach file test

* fix

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants