[ADF-5235] Facet fix and improve search test #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eromano
requested review from
cristinaj,
DenysVuika and
popovicsandras
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6122 +/- ##
===========================================
- Coverage 76.33% 76.28% -0.05%
===========================================
Files 850 850
Lines 18983 18982 -1
Branches 3751 3753 +2
===========================================
- Hits 14491 14481 -10
- Misses 3360 3365 +5
- Partials 1132 1136 +4
Continue to review full report at Codecov.
|
eromano
force-pushed
the
dev-eromano-search-improve
branch
from
95db43b
to
bf2691f
Compare
eromano
force-pushed
the
dev-eromano-search-improve
branch
from
2ddc5ba
to
368deae
Compare
eromano
force-pushed
the
dev-eromano-search-improve
branch
from
508b9da
to
56fba57
Compare
eromano
force-pushed
the
dev-eromano-search-improve
branch
from
82682ce
to
bcd6650
Compare
eromano
force-pushed
the
dev-eromano-search-improve
branch
from
5b3a740
to
97a1938
Compare
VitoAlbano
approved these changes
Sep 21, 2020
|
|
||
| try { | ||
| await BrowserVisibility.waitUntilElementIsVisible(this.logoutSection); | ||
| } catch (error) { |
There was a problem hiding this comment.
Since we're using the logger already perhaps we could use it to show the error thrown here so it's easier to spot in the future where it's failing?
| try { | ||
| Logger.log('wait loading spinner is present'); | ||
| await BrowserVisibility.waitUntilElementIsPresent(element(by.tagName('mat-spinner'))); | ||
| } catch (error) { |
There was a problem hiding this comment.
same here with the logger and the error.
| @@ -89,14 +113,15 @@ export class BrowserActions { | |||
| } | |||
| } | |||
|
|
|||
| static async getTextScript(elementFinder: ElementFinder): Promise<string> { | |||
| // Don't make it pub,ic use getText | |||
There was a problem hiding this comment.
Nothing should be pubic on ADF :P
VitoAlbano
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Facet fix and improve search test
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: