Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-4481] e2e test for uploading an unsupported file #6141

Merged
merged 3 commits into from Sep 29, 2020

Conversation

AleAb25
Copy link
Contributor

@AleAb25 AleAb25 commented Sep 18, 2020

Please check if the PR fulfills these requirements

  • [ x] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • [ x] Other... Please describe:
    e2e test automation

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-4481

What is the new behaviour?

e2e test automation

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #6141 into develop will increase coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6141      +/-   ##
===========================================
+ Coverage    76.19%   77.56%   +1.37%     
===========================================
  Files          859      144     -715     
  Lines        19349     4025   -15324     
  Branches      3841      800    -3041     
===========================================
- Hits         14743     3122   -11621     
+ Misses        3456      645    -2811     
+ Partials      1150      258     -892     
Impacted Files Coverage Δ
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
...rocess/start-process/start-process-cloud.module.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
...nts/activities/diagram-rest-call-task.component.ts
lib/core/services/comment-process.service.ts
...core/context-menu/context-menu-holder.component.ts
.../core/card-view/models/card-view-baseitem.model.ts
lib/core/pipes/localized-date.pipe.ts
...s-cloud/src/lib/task/task-form/task-form.module.ts
...ponents/activities/diagram-camel-task.component.ts
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8453f93...b640452. Read the comment docs.

@davidcanonieto davidcanonieto merged commit 06f57a6 into develop Sep 29, 2020
@davidcanonieto davidcanonieto deleted the dev-AleAb-ADF-4481 branch September 29, 2020 15:53
arditdomi pushed a commit that referenced this pull request Sep 30, 2020
…https://github.com/Alfresco/alfresco-ng2-components into develop

* 'mvitale-AAE-3199-node-selector-facet' of https://github.com/Alfresco/alfresco-ng2-components:
  Fix api compatibility
  Fix comments
  Fix wrong import
  Fix wrong import and constructor injection comments
  Fix existing unit tests
  Fix build errors to launch unit tests
  more refactoring, remove injecting the SearchQueryBuilderService from the content node selector service
  Avoid having more services extending BaseQueryBuilderService
  Fix service injection - create one new instance for content-node-selector component
  More refactoring
  First refactoring - Fix global search and service injection issues
  Replace
  Create new panel component and search refactoring

* 'develop' of https://github.com/Alfresco/alfresco-ng2-components:
  Bump pdfjs-dist from 2.4.456 to 2.5.207 (#6170)
  fix beta release script
  Bump @types/node from 14.6.4 to 14.11.2 (#6189)
  Bump lint-staged from 10.2.13 to 10.4.0 (#6188)
  Bump snyk from 1.393.0 to 1.404.0 (#6187)
  [ACA-3626] Cloud Task - completed date filter  (#6185)
  [ADF-4481] e2e test for uploading an unsupported file (#6141)
  [ADF-5260] Fix Service task list initialization in DemoShell (#6184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants