[ACA-3692] - Add completed date/due date/started date filter #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilviuCPopa
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
|
Silviu Popa seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Please fix the unit tests |
popovicsandras
requested changes
Sep 23, 2020
...ices-cloud/src/lib/process/process-filters/components/edit-process-filter-cloud.component.ts
Outdated
Show resolved
Hide resolved
lib/process-services-cloud/src/lib/process/process-filters/models/process-filter-cloud.model.ts
Outdated
Show resolved
Hide resolved
popovicsandras
changed the title
SilviuCPopa
force-pushed
the
dev-spopa-ACA-3692
branch
from
f4654db
to
c21f6ac
Compare
popovicsandras
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Given the close deadline, I approve it, but please for the marked duplication types create a separate Jira ticket in the next Technical Debt/Maintenance epic and assign to yourself and put into the sprint. (I think it is quite clear what I mean by the marked duplications, otherwise, let's discuss)
| } | ||
| } | ||
|
|
||
| set completedFrom(completedFrom: string) { |
There was a problem hiding this comment.
Duplication type #1
| @@ -170,18 +170,22 @@ export class EditTaskFilterCloudComponent implements OnInit, OnChanges, OnDestro | |||
|
|
|||
| getFormControlsConfig(taskFilterProperties: TaskFilterProperties[]): any { | |||
| const properties = taskFilterProperties.map((property: TaskFilterProperties) => { | |||
| if (!property.rangeKeys) { | |||
| return { [property.key]: property.value }; | |||
| if (!!property.attributes) { | |||
There was a problem hiding this comment.
Duplication type #2
Codecov Report
@@ Coverage Diff @@
## develop #6145 +/- ##
===========================================
+ Coverage 75.33% 78.41% +3.08%
===========================================
Files 624 339 -285
Lines 14803 9277 -5526
Branches 3089 1880 -1209
===========================================
- Hits 11152 7275 -3877
+ Misses 2722 1421 -1301
+ Partials 929 581 -348
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3692
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: