Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3973] K8s image - fetch all the namespaces and handle the missing container #6148

Merged
merged 1 commit into from Sep 22, 2020

Conversation

mauriziovitale
Copy link
Contributor

… case of missing container for a label

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #6148 into develop will increase coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6148      +/-   ##
===========================================
+ Coverage    76.28%   77.80%   +1.51%     
===========================================
  Files          850      143     -707     
  Lines        18978     4005   -14973     
  Branches      3752      801    -2951     
===========================================
- Hits         14477     3116   -11361     
+ Misses        3366      630    -2736     
+ Partials      1135      259     -876     
Impacted Files Coverage Δ
lib/core/services/search.service.ts
...gram/components/diagram-sequence-flow.component.ts
...lib/task/task-header/mocks/fake-claim-task.mock.ts
lib/core/services/translation.service.ts
...ts/dynamic-table/editors/boolean/boolean.editor.ts
...nents/raphael/icons/raphael-icon-mule.component.ts
...process-list/components/start-process.component.ts
...le/directives/custom-loading-template.directive.ts
.../task/task-header/mocks/fake-complete-task.mock.ts
...onents/activities/diagram-script-task.component.ts
... and 698 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0b09f...f5ad884. Read the comment docs.

@mauriziovitale mauriziovitale merged commit 4638360 into develop Sep 22, 2020
@mauriziovitale mauriziovitale deleted the mvitale-ACA-3973-k8s-publish branch September 22, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants