Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3899] Viewer thumbnails cannot be accessed by keyboard #6150

Merged
merged 12 commits into from Sep 23, 2020

Conversation

pionnegru
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ACA-3899

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #6150 into develop will increase coverage by 1.32%.
The diff coverage is 97.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6150      +/-   ##
===========================================
+ Coverage    75.35%   76.68%   +1.32%     
===========================================
  Files          624      843     +219     
  Lines        14849    18882    +4033     
  Branches      3119     3746     +627     
===========================================
+ Hits         11190    14479    +3289     
- Misses        2718     3260     +542     
- Partials       941     1143     +202     
Impacted Files Coverage Δ
...ewer/components/pdf-viewer-thumbnails.component.ts 96.38% <96.87%> (-0.17%) ⬇️
...re/viewer/components/pdf-viewer-thumb.component.ts 100.00% <100.00%> (ø)
lib/core/viewer/components/pdf-viewer.component.ts 83.42% <100.00%> (-0.47%) ⬇️
...b/core/context-menu/context-menu-list.component.ts 50.00% <0.00%> (-5.56%) ⬇️
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
lib/extensions/src/lib/config/extension-utils.ts
...b/extensions/src/lib/services/extension.service.ts
lib/extensions/src/test.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
... and 234 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472e112...7367743. Read the comment docs.

@eromano eromano merged commit 3da5196 into develop Sep 23, 2020
@eromano eromano deleted the dev-pionnegru-ACA-3899 branch September 23, 2020 04:57
@pr-triage pr-triage bot added the PR: merged label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants