Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3977] FE - Integrate new user assign API #6157

Merged
merged 2 commits into from Sep 24, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3977

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-ACA-3977-integrate-user-assign-api branch from 35e1f8a to 0895bdb Compare September 24, 2020 04:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #6157 into develop will increase coverage by 2.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6157      +/-   ##
===========================================
+ Coverage    76.29%   78.40%   +2.10%     
===========================================
  Files          852      339     -513     
  Lines        19067     9285    -9782     
  Branches      3779     1881    -1898     
===========================================
- Hits         14548     7280    -7268     
+ Misses        3378     1424    -1954     
+ Partials      1141      581     -560     
Impacted Files Coverage Δ
...-cloud/src/lib/task/services/task-cloud.service.ts 79.48% <100.00%> (+2.02%) ⬆️
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
...n/date-range-filter/date-range-filter.component.ts 92.59% <0.00%> (-1.86%) ⬇️
...mon/date-range-filter/date-range-filter.service.ts 86.36% <0.00%> (-0.60%) ⬇️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
lib/core/mock/form/form.component.mock.ts
lib/core/mock/comment-content-service.mock.ts
...dgets/dynamic-table/number-cell-validator.model.ts
lib/core/search-text/search-text-input.module.ts
lib/core/services/user-preferences.service.ts
... and 515 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67b3b8...775d0ad. Read the comment docs.

Copy link
Contributor

@mauriziovitale mauriziovitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comments

@mauriziovitale mauriziovitale merged commit fe61c6d into develop Sep 24, 2020
@mauriziovitale mauriziovitale deleted the dev-siva-ACA-3977-integrate-user-assign-api branch September 24, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants