Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3493] Update the documentation to provide the proper guidance on custom forms widgets for APA and APS developers #6158

Merged
merged 22 commits into from Sep 25, 2020

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Sep 24, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I've understood the functionality correctly and this still makes sense and I can take a look at the APS stencil section too.

docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
docs/user-guide/aae-extensions.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
dhrn and others added 11 commits September 25, 2020 10:50
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
dhrn and others added 3 commits September 25, 2020 10:59
Co-authored-by: Mark Hulbert <39801222+m-hulbert@users.noreply.github.com>
@dhrn dhrn requested a review from m-hulbert September 25, 2020 06:55
Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link

Codecov Report

Merging #6158 into develop will increase coverage by 1.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6158      +/-   ##
===========================================
+ Coverage    76.31%   77.61%   +1.30%     
===========================================
  Files          850      144     -706     
  Lines        18981     4025   -14956     
  Branches      3753      799    -2954     
===========================================
- Hits         14485     3124   -11361     
+ Misses        3360      643    -2717     
+ Partials      1136      258     -878     
Impacted Files Coverage Δ
...ocument-list/components/document-list.component.ts 83.53% <0.00%> (-0.78%) ⬇️
...ices/src/lib/document-list/document-list.module.ts 100.00% <0.00%> (ø)
...t/components/process-instance-details.component.ts
lib/core/services/get-type.ts
...ces/src/lib/task-list/models/task-details.event.ts
.../lib/process-list/models/process-instance.model.ts
...src/lib/task/directives/complete-task.directive.ts
...ib/task/directives/unclaim-task-cloud.directive.ts
lib/core/layout/layout.module.ts
...ss-list/components/process-list-cloud.component.ts
... and 704 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b02233...44e7122. Read the comment docs.

@eromano eromano merged commit d7f0fa5 into develop Sep 25, 2020
@eromano eromano deleted the dev-dhrn-AAE-3493 branch September 25, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants