Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3410] NodeSelector - Use user alias (-my-) name as default for upload of type Alfresco Content only #6160

Merged
merged 3 commits into from Sep 27, 2020

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #6160 into develop will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6160      +/-   ##
===========================================
+ Coverage    77.90%   78.31%   +0.40%     
===========================================
  Files          249      340      +91     
  Lines         6821     9315    +2494     
  Branches      1410     1883     +473     
===========================================
+ Hits          5314     7295    +1981     
- Misses        1054     1439     +385     
- Partials       453      581     +128     
Impacted Files Coverage Δ
.../attach-file/attach-file-cloud-widget.component.ts 85.91% <100.00%> (+0.20%) ⬆️
...process-list/components/process-audit.directive.ts 96.15% <0.00%> (ø)
lib/process-services/src/lib/form/form.module.ts 100.00% <0.00%> (ø)
...c/lib/people/components/people/people.component.ts 58.82% <0.00%> (ø)
...ess-services/src/lib/task-list/task-list.module.ts 100.00% <0.00%> (ø)
.../src/lib/process-list/models/process-list.model.ts 83.33% <0.00%> (ø)
...s/src/lib/mock/task/task-details.component.mock.ts 100.00% <0.00%> (ø)
...ib/process-list/services/process-filter.service.ts 91.48% <0.00%> (ø)
...ces/src/lib/form/form-custom-outcomes.component.ts 100.00% <0.00%> (ø)
...es/src/lib/content-widget/content-widget.module.ts 100.00% <0.00%> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84ef73...be902ef. Read the comment docs.

@mauriziovitale mauriziovitale changed the title [AAE-3410] NodeSelector - Use root alias name as default for upload of type Alfresco Content only [AAE-3410] NodeSelector - Use user alias (-my-) name as default for upload of type Alfresco Content only Sep 25, 2020
@eromano eromano merged commit c40614f into develop Sep 27, 2020
@eromano eromano deleted the mvitale-AAE-3410-default-root branch September 27, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants