Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improve 2 #6167

Merged
merged 7 commits into from Sep 27, 2020
Merged

Test improve 2 #6167

merged 7 commits into from Sep 27, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Sep 27, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Test improve 2

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano eromano marked this pull request as draft September 27, 2020 09:02
@eromano eromano removed the request for review from cristinaj September 27, 2020 09:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2020

Codecov Report

Merging #6167 into develop will increase coverage by 0.95%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6167      +/-   ##
===========================================
+ Coverage    75.37%   76.33%   +0.95%     
===========================================
  Files          624      852     +228     
  Lines        14906    19172    +4266     
  Branches      3121     3812     +691     
===========================================
+ Hits         11235    14634    +3399     
- Misses        2733     3387     +654     
- Partials       938     1151     +213     
Impacted Files Coverage Δ
...ission-manager/services/node-permission.service.ts 90.16% <0.00%> (-1.64%) ⬇️
.../lib/search/search-filter-query-builder.service.ts
...ts/icons/diagram-container-icon-event.component.ts 100.00% <0.00%> (ø)
...ents/raphael/icons/raphael-icon-timer.component.ts 100.00% <0.00%> (ø)
...ces/src/lib/form/form-custom-outcomes.component.ts 100.00% <0.00%> (ø)
...ivities/diagram-alfresco-publish-task.component.ts 100.00% <0.00%> (ø)
...ns/diagram-icon-alfresco-publish-task.component.ts 100.00% <0.00%> (ø)
...b/process-services/src/lib/people/people.module.ts 100.00% <0.00%> (ø)
.../components/icons/diagram-icon-signal.component.ts 100.00% <0.00%> (ø)
...s/boundary-events/diagram-throw-event.component.ts 100.00% <0.00%> (ø)
... and 222 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ce7d0...8dceed2. Read the comment docs.

@eromano eromano marked this pull request as ready for review September 27, 2020 23:04
@eromano eromano merged commit 7fb42d7 into develop Sep 27, 2020
@eromano eromano deleted the dev-eromano-test-improve2 branch September 27, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants