Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken e2e tests because of the lack of thrown error #6180

Merged
merged 1 commit into from Sep 28, 2020

Conversation

popovicsandras
Copy link
Contributor

The e2es in the ADF apps are broken.

@codecov-commenter
Copy link

Codecov Report

Merging #6180 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6180      +/-   ##
===========================================
+ Coverage    77.50%   77.56%   +0.06%     
===========================================
  Files          256      144     -112     
  Lines         6997     4025    -2972     
  Branches      1440      800     -640     
===========================================
- Hits          5423     3122    -2301     
+ Misses        1121      645     -476     
+ Partials       453      258     -195     
Impacted Files Coverage Δ
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
...lib/form/services/process-cloud-content.service.ts
...rc/lib/people/components/people-cloud.component.ts
...mon/date-range-filter/date-range-filter.service.ts
...ess/process-list/mock/process-list-service.mock.ts
...rocess/components/start-process-cloud.component.ts
...src/lib/app/components/app-list-cloud.component.ts
...components/service-task-filters-cloud.component.ts
...ices-cloud/src/lib/process/process-cloud.module.ts
...es-cloud/src/lib/models/date-cloud-filter.model.ts
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abdf07...126d1ec. Read the comment docs.

@eromano eromano merged commit 5ff3852 into develop Sep 28, 2020
@eromano eromano deleted the dev-apopovics-fix-adf-testing branch September 28, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants