[AAE-3694] Add new Service Method for service task integration #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcanonieto
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6199 +/- ##
===========================================
+ Coverage 75.99% 78.11% +2.11%
===========================================
Files 747 350 -397
Lines 16377 9553 -6824
Branches 3201 1927 -1274
===========================================
- Hits 12446 7462 -4984
+ Misses 2974 1509 -1465
+ Partials 957 582 -375
Continue to review full report at Codecov.
|
eromano
approved these changes
Oct 1, 2020
| */ | ||
| getServiceTaskStatus(appName: string, serviceTaskId: string): Observable<ServiceTaskIntegrationContextCloudModel> { | ||
| if (appName) { | ||
| const queryUrl = `${this.getBasePath(appName)}/query/admin/v1/service-tasks/${serviceTaskId}/integration-context`; |
There was a problem hiding this comment.
are you sure that is right to call an admin API ?
mauriziovitale
requested changes
Oct 1, 2020
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: partially-approved
labels
popovicsandras
approved these changes
Oct 1, 2020
mauriziovitale
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3694
What is the new behaviour?
This PR adds a new method to get more information about the service task integration context.
It also fixes some cosmetic issues in the service-task-demo-page.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: