Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5261] Fix excluded flaky tests C297689, C297690 #6212

Merged
merged 2 commits into from Oct 5, 2020

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Oct 5, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ADF-5261

What is the new behaviour?

fixed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #6212 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6212      +/-   ##
===========================================
+ Coverage    76.24%   76.28%   +0.04%     
===========================================
  Files          862      862              
  Lines        19415    19415              
  Branches      3855     3855              
===========================================
+ Hits         14802    14811       +9     
+ Misses        3461     3451      -10     
- Partials      1152     1153       +1     
Impacted Files Coverage Δ
lib/core/services/upload.service.ts 88.82% <0.00%> (+3.35%) ⬆️
.../lib/task-list/components/attach-form.component.ts 51.28% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae2560...65825b0. Read the comment docs.

@DenysVuika DenysVuika merged commit c75896e into develop Oct 5, 2020
@DenysVuika DenysVuika deleted the dev-dhrn-ADF-5261 branch October 5, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants