Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3719][AAE-3720] - Fix content node selector search should align with the filtering #6214

Merged
merged 10 commits into from Oct 20, 2020

Conversation

arditdomi
Copy link
Contributor

@arditdomi arditdomi commented Oct 5, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3719
https://issues.alfresco.com/jira/browse/AAE-3720

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Oct 5, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #6214 into develop will increase coverage by 2.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6214      +/-   ##
===========================================
+ Coverage    76.27%   78.66%   +2.38%     
===========================================
  Files          862      204     -658     
  Lines        19420     5511   -13909     
  Branches      3855     1125    -2730     
===========================================
- Hits         14813     4335   -10478     
+ Misses        3453      854    -2599     
+ Partials      1154      322     -832     
Impacted Files Coverage Δ
...b/extensions/src/lib/services/extension.service.ts
.../widgets/dynamic-table/editors/text/text.editor.ts
...nalytics-process/components/analytics.component.ts
...c/lib/document-list/models/content-action.model.ts
...ts/icons/diagram-container-icon-event.component.ts
lib/core/mock/renditions-service.mock.ts
.../lib/search/search-header-query-builder.service.ts
.../components/search-filter/search-filter.service.ts
lib/core/services/auth-guard-bpm.service.ts
lib/core/mock/apps-service.mock.ts
... and 646 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce1aeb...f2140e0. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #6214 into develop will increase coverage by 1.90%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6214      +/-   ##
===========================================
+ Coverage    76.25%   78.15%   +1.90%     
===========================================
  Files          862      350     -512     
  Lines        19457     9585    -9872     
  Branches      3870     1938    -1932     
===========================================
- Hits         14836     7491    -7345     
+ Misses        3460     1510    -1950     
+ Partials      1161      584     -577     
Impacted Files Coverage Δ
...tent-widget/attach-file-widget-dialog.component.ts 77.77% <ø> (ø)
...vices/src/lib/search/base-query-builder.service.ts 84.50% <75.00%> (+1.17%) ⬆️
...-selector/content-node-selector-panel.component.ts 85.55% <85.10%> (-0.92%) ⬇️
...content-services/src/lib/mock/search-query.mock.ts 100.00% <100.00%> (ø)
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
...omponents/filesize-cell/filesize-cell.component.ts
lib/insights/src/lib/insights.module.ts
lib/core/services/lock.service.ts
lib/core/mock/form/form.component.mock.ts
... and 515 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e8ff2...9e71bc9. Read the comment docs.

@arditdomi arditdomi changed the title [AAE-3719] - Fix content node selector search should align with the filtering [AAE-3719][AAE-3720] - Fix content node selector search should align with the filtering Oct 19, 2020
@eromano eromano merged commit 072f910 into develop Oct 20, 2020
@eromano eromano deleted the dev-adomi-AAE-3719 branch October 20, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants