New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAE-3719][AAE-3720] - Fix content node selector search should align with the filtering #6214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arditdomi
force-pushed
the
dev-adomi-AAE-3719
branch
from
October 6, 2020 14:37
b969b6b
to
f2140e0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6214 +/- ##
===========================================
+ Coverage 76.25% 78.15% +1.90%
===========================================
Files 862 350 -512
Lines 19457 9585 -9872
Branches 3870 1938 -1932
===========================================
- Hits 14836 7491 -7345
+ Misses 3460 1510 -1950
+ Partials 1161 584 -577
Continue to review full report at Codecov.
|
arditdomi
force-pushed
the
dev-adomi-AAE-3719
branch
from
October 14, 2020 15:37
faf1d9d
to
5a65701
Compare
arditdomi
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
October 16, 2020 12:01
DenysVuika
requested changes
Oct 16, 2020
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.component.ts
Show resolved
Hide resolved
DenysVuika
approved these changes
Oct 16, 2020
pr-triage
bot
added
PR: partially-approved
and removed
PR: reviewed-changes-requested
labels
Oct 16, 2020
eromano
requested changes
Oct 16, 2020
lib/content-services/src/lib/content-node-selector/content-node-selector.service.spec.ts
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: partially-approved
labels
Oct 16, 2020
…earch service instead
arditdomi
force-pushed
the
dev-adomi-AAE-3719
branch
from
October 19, 2020 10:46
4f97ef6
to
9e71bc9
Compare
arditdomi
changed the title
[AAE-3719] - Fix content node selector search should align with the filtering
[AAE-3719][AAE-3720] - Fix content node selector search should align with the filtering
Oct 19, 2020
eromano
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3719
https://issues.alfresco.com/jira/browse/AAE-3720
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: