Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5279] Date range type filter selection triggers list reload #6253

Merged
merged 2 commits into from Oct 19, 2020

Conversation

pionnegru
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
ADF-5279

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #6253 into develop will increase coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6253      +/-   ##
===========================================
+ Coverage    76.29%   78.23%   +1.94%     
===========================================
  Files          862      237     -625     
  Lines        19427     6543   -12884     
  Branches      3857     1275    -2582     
===========================================
- Hits         14821     5119    -9702     
+ Misses        3451     1035    -2416     
+ Partials      1155      389     -766     
Impacted Files Coverage Δ
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
...omponents/filesize-cell/filesize-cell.component.ts
lib/insights/src/lib/insights.module.ts
...d/src/lib/form/models/task-variable-cloud.model.ts
lib/core/services/lock.service.ts
lib/core/mock/form/form.component.mock.ts
...ble/directives/header-filter-template.directive.ts
...sk-header/mocks/fake-task-details-response.mock.ts
lib/core/pipes/user-initial.pipe.ts
lib/core/userinfo/userinfo.module.ts
... and 615 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f3daa...562a1c8. Read the comment docs.

@eromano eromano merged commit eaa9a2c into develop Oct 19, 2020
@eromano eromano deleted the dev-pionnegru-ADF-5279 branch October 19, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants