Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default login with admin if not to create user e2e #6260

Merged
merged 1 commit into from Oct 16, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Oct 16, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Default login with admin if not to create user e2e

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #6260 into develop will increase coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6260      +/-   ##
===========================================
+ Coverage    76.27%   77.43%   +1.15%     
===========================================
  Files          862      146     -716     
  Lines        19427     4050   -15377     
  Branches      3857      802    -3055     
===========================================
- Hits         14818     3136   -11682     
+ Misses        3455      653    -2802     
+ Partials      1154      261     -893     
Impacted Files Coverage Δ
...-view/validators/card-view-item-minmax.valiator.ts
...ponents/activities/diagram-camel-task.component.ts
...core/context-menu/context-menu-holder.component.ts
...rocess-services/src/lib/pipes/process-name.pipe.ts
lib/extensions/src/lib/config/extension-utils.ts
...nents/raphael/icons/raphael-icon-mule.component.ts
lib/core/dialogs/dialog.module.ts
...am/components/activities/diagram-task.component.ts
...tart-task/models/start-task-cloud-request.model.ts
...src/lib/app/services/apps-process-cloud.service.ts
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 951ecab...2948e9b. Read the comment docs.

@DenysVuika DenysVuika merged commit 04f5e35 into develop Oct 16, 2020
@DenysVuika DenysVuika deleted the dev-eromano-default-login branch October 16, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants