Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4099] Fix search query in content node selector #6299

Merged
merged 1 commit into from Nov 4, 2020

Conversation

arditdomi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4099

What is the new behaviour?
The * has been added in the search service query. It was removed in a previous refactoring but it is now needed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #6299 into develop will increase coverage by 1.93%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6299      +/-   ##
===========================================
+ Coverage    76.26%   78.19%   +1.93%     
===========================================
  Files          864      352     -512     
  Lines        19583     9683    -9900     
  Branches      3901     1959    -1942     
===========================================
- Hits         14935     7572    -7363     
+ Misses        3475     1517    -1958     
+ Partials      1173      594     -579     
Impacted Files Coverage Δ
...content-services/src/lib/mock/search-query.mock.ts 100.00% <ø> (ø)
...-selector/content-node-selector-panel.component.ts 85.32% <100.00%> (ø)
...omponents/location-cell/location-cell.component.ts
lib/core/pipes/user-initial.pipe.ts
...nts/gateways/diagram-parallel-gateway.component.ts
...re/form/components/widgets/upload/upload.widget.ts
lib/core/models/decimal-number.model.ts
lib/core/login/models/login-success.event.ts
.../widgets/dynamic-table/editors/text/text.editor.ts
...nsights/src/lib/testing/insights.testing.module.ts
... and 505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456e042...2cf4dcd. Read the comment docs.

@arditdomi arditdomi merged commit 7bb3c30 into develop Nov 4, 2020
@arditdomi arditdomi deleted the dev-adomi-ACA-4099 branch November 4, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants