Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5223] Fix Amount widget styling #6302

Merged
merged 4 commits into from Nov 5, 2020
Merged

[ADF-5223] Fix Amount widget styling #6302

merged 4 commits into from Nov 5, 2020

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Nov 3, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ADF-5223

What is the new behaviour?
This widget wasn't representing the prefix correctly as it was hacked and hardcoded. Now it adapts to whatever currency is in use keeping the spacing in between.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #6302 into develop will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6302      +/-   ##
===========================================
+ Coverage    76.28%   76.58%   +0.29%     
===========================================
  Files          864      856       -8     
  Lines        19583    19324     -259     
  Branches      3901     3822      -79     
===========================================
- Hits         14939    14799     -140     
+ Misses        3470     3369     -101     
+ Partials      1174     1156      -18     
Impacted Files Coverage Δ
...k-filters/base-edit-task-filter-cloud.component.ts 71.83% <0.00%> (-5.41%) ⬇️
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
.../components/edit-process-filter-cloud.component.ts 72.58% <0.00%> (-2.06%) ⬇️
...s/search-date-range/search-date-range.component.ts 63.01% <0.00%> (-0.63%) ⬇️
...b/content-services/src/lib/search/search.module.ts 100.00% <0.00%> (ø)
...ontent-services/src/lib/mock/search-filter-mock.ts 100.00% <0.00%> (ø)
...d/src/lib/form/models/task-variable-cloud.model.ts 0.00% <0.00%> (ø)
.../components/search-filter/search-filter.service.ts 100.00% <0.00%> (ø)
.../components/dynamic-component/dynamic.component.ts
lib/extensions/src/lib/services/rule.service.ts
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea79a...db4024a. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Nov 4, 2020

@davidcanonieto still a minor e2e to fix please check the travis CI

@eromano eromano merged commit 91b7458 into develop Nov 5, 2020
@eromano eromano deleted the dev-dcano-ADF-5223 branch November 5, 2020 14:00
@pr-triage pr-triage bot added the PR: merged label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants