Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4057] Edit getProcessInstanceByName method to search the process instance directly by its name #6303

Merged
merged 3 commits into from Nov 4, 2020

Conversation

iuliaib
Copy link
Contributor

@iuliaib iuliaib commented Nov 3, 2020

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Adding this size value because default is 25 which is too small
@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #6303 into develop will increase coverage by 1.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6303      +/-   ##
===========================================
+ Coverage    76.28%   77.58%   +1.29%     
===========================================
  Files          864      147     -717     
  Lines        19583     4068   -15515     
  Branches      3901      806    -3095     
===========================================
- Hits         14939     3156   -11783     
+ Misses        3470      646    -2824     
+ Partials      1174      266     -908     
Impacted Files Coverage Δ
...b/core/form/components/widgets/tabs/tabs.widget.ts
lib/core/models/pagination.model.ts
...cess-services/src/lib/app-list/apps-list.module.ts
...-cloud/src/lib/task/services/task-cloud.service.ts
...d/src/lib/app/models/application-instance.model.ts
...am/components/activities/diagram-task.component.ts
lib/core/directives/node-restore.directive.ts
...src/lib/mock/analytics/analytics-component.mock.ts
...rc/lib/task/task-list/models/filter-cloud-model.ts
lib/core/mock/form/form.service.mock.ts
... and 707 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aea79a...9201b3a. Read the comment docs.

@iuliaib iuliaib changed the title [ACA-4057] Add size value to getProcessInstanceByName [ACA-4057] Edit getProcessInstanceByName method to search the process instance directly by its name Nov 3, 2020
@iuliaib iuliaib merged commit fff574c into develop Nov 4, 2020
@iuliaib iuliaib deleted the dev-iburca-ACA-4057 branch November 4, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants